Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard is weak #25

Open
androidmitry opened this issue Oct 23, 2018 · 3 comments
Open

Proguard is weak #25

androidmitry opened this issue Oct 23, 2018 · 3 comments

Comments

@androidmitry
Copy link

Hello everyone. Thanks for creating this awesome library.
I faced some unusual problem. Proguard doesn't obfuscate code as I expect.
I reviewed [https://github.com/saschpe/android-customtabs/blob/master/customtabs/proguard-rules.pro](Proguard rules) in the library and it looks like that this rule is too generic
-keep public class * { public protected *; }
This rule forces Proguard to keep all classes with public and protected fields.
Thanks for help.

@sergivonavi
Copy link

Completely agree with it. Spent several hours until I figured this out.
@saschpe can you, please, change this rule?

@igorvilela28
Copy link

Is this issue gonna be addressed? I lost an entire morning trying to figure out why my proguard wasn't obfuscating anything.

This library works very well, but it completely disables the proguard.

saschpe added a commit that referenced this issue May 16, 2019
Avoids keeping public classes in downstream applications.

Fixes issue #25.
@saschpe
Copy link
Owner

saschpe commented May 16, 2019

Version 2.0.3 should fix that. The library shipped the proguard-rules.pro file used to build it's release flavor. That wasn't actually necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants