comply with XDG Base Directory Specification (fixes #13) #14
Conversation
|
Hmm, according to XDG, created reports and other user data which isn't config should actually go in |
|
OK, I think this is good to merge now. |
| @@ -0,0 +1,27 @@ | |||
| # Copyright (c) 2013, Sascha Peilicke <saschpe@gmx.de> | |||
There was a problem hiding this comment.
Wouldn't you have to add your name here? ;-)
|
Have you looked at the Python XDG bindings, i.e. http://pyxdg.readthedocs.org/en/latest/index.html ? I think it's worth using it for complying to the Base Directory spec. |
|
Drat, you're right (if you're OK with the extra dependency, that is). Maybe worth merging this as an intermediate step and then switching it to use PyXDG later? Probably easier than reworking this PR. |
|
Sure, makes sense to me. Generally, I'm fine with extra dependencies since it's less code to take care here. With regards to openSUSE, we're in the comfortable situation that we have all those deps packaged. I only try to avoid dependencies if they bring many transitive dependencies or if they add little gain. For instance, most Github bindings (applies to any programming language) are so over-engineered that a simple GET request to a JSON route is usually my preferred way to go. When programming in Python, I tend to pick whatever makes the code simpler and more obvious. As an example, once I figured out what I can get from Launchpad via plain HTTP, I probably want to drop launchpadlib since it's really ugly and depends on countless other (bad) Python packages. |
| /etc/rapport/ | ||
| """ | ||
| config_dirs = [ | ||
| os.path.expanduser(os.path.join("~", ".rapport")), | ||
| USER_CONFIG_DIR, |
There was a problem hiding this comment.
In order to have a migration path for existing users, I'd rather just add the USER_CONFIG_DIR line above and not drop the old config location. Alternatively, we should move the old config file to the new location.
|
Rebased onto latest upstream master. Remaining issues not addressed yet. |
User config tree now defaults to ~/.config/rapport, and reports dir to ~/.local/share/rapport/reports. Added a new unit test for the latter. http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
|
Rebased again, and ditto. |
Let's have it merged then. I'll add another commit to keep the old config locations with lower priority. If necessary, migration code can still be written later on
User config tree now defaults to
~/.config/rapportI'm not 100% sure this works yet, because I still have a test failure ...