Improve (#356) to support registration of wildcard URLs #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 17 17
Lines 670 670
=======================================
Hits 638 638
Misses 22 22
Partials 10 10 |
|
@sashabaranov please review. I have a larger PR I'm working on for Azure DALL-E 2 support, however this is a simple change which allows test support for Azure OpenAI endpoints. |
|
@sashabaranov let me know if you have any questions about the need for wildcard support in the test handlers? If the project is going to provide first class support for Azure OpenAI then support for wildcard handlers is required due to the deployment name being a component of the URL structure : /openai/deployments/{model}/chat/completions?api-version={api_version} |
vvatanabe
reviewed
Jun 14, 2023
|
LGTM |
models: add *-0613 models (sashabaranov#361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve on (#356) issue to support wildcard URLs required by Azure API path structure
Add Azure ChatCompletions test cases including test of custom deployment name