feat: add constant.Kind

pkg/analyzer/analyzer.go

@@ -24,6 +24,7 @@ const (
 	OSDevNullFlag          = "os-dev-null"
 	SQLIsolationLevelFlag  = "sql-isolation-level"
 	TLSSignatureSchemeFlag = "tls-signature-scheme"
+	ConstantKindFlag       = "constant-kind"
 )
 
 // New returns new usestdlibvars analyzer.
@@ -49,6 +50,7 @@ func flags() flag.FlagSet {
 	flags.Bool(OSDevNullFlag, false, "suggest the use of os.DevNull")
 	flags.Bool(SQLIsolationLevelFlag, false, "suggest the use of sql.LevelXX.String()")
 	flags.Bool(TLSSignatureSchemeFlag, false, "suggest the use of tls.SignatureScheme.String()")
+	flags.Bool(ConstantKindFlag, false, "suggest the use of constant.Kind.String()")
 	return *flags
 }
 
@@ -91,6 +93,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
 				{flag: OSDevNullFlag, checkFunc: checkOSDevNull},
 				{flag: SQLIsolationLevelFlag, checkFunc: checkSQLIsolationLevel},
 				{flag: TLSSignatureSchemeFlag, checkFunc: checkTLSSignatureScheme},
+				{flag: ConstantKindFlag, checkFunc: checkConstantKind},
 			} {
 				if lookupFlag(pass, c.flag) {
 					c.checkFunc(pass, n)
@@ -438,6 +441,14 @@ func checkTLSSignatureScheme(pass *analysis.Pass, basicLit *ast.BasicLit) {
 	}
 }
 
+func checkConstantKind(pass *analysis.Pass, basicLit *ast.BasicLit) {
+	currentVal := getBasicLitValue(basicLit)
+
+	if newVal, ok := mapping.ConstantKind[currentVal]; ok {
+		report(pass, basicLit.Pos(), currentVal, newVal)
+	}
+}
+
 // getBasicLitFromArgs gets the *ast.BasicLit of a function argument.
 //
 // Arguments:

pkg/analyzer/analyzer_test.go

@@ -17,6 +17,7 @@ func TestUseStdlibVars(t *testing.T) {
 		"a/os",
 		"a/sql",
 		"a/tls",
+		"a/constant",
 	}
 
 	a := analyzer.New()
@@ -29,6 +30,7 @@ func TestUseStdlibVars(t *testing.T) {
 	mustNil(t, a.Flags.Set(analyzer.OSDevNullFlag, "true"))
 	mustNil(t, a.Flags.Set(analyzer.SQLIsolationLevelFlag, "true"))
 	mustNil(t, a.Flags.Set(analyzer.TLSSignatureSchemeFlag, "true"))
+	mustNil(t, a.Flags.Set(analyzer.ConstantKindFlag, "true"))
 
 	analysistest.Run(t, analysistest.TestData(), a, pkgs...)
 }

pkg/analyzer/internal/gen.go

@@ -97,10 +97,16 @@ func main() {
 		},
 		{
 			mapping:      mapping.TLSSignatureScheme,
-			packageName:  "sql_test",
+			packageName:  "tls_test",
 			templateName: "test-template.go.tmpl",
 			fileName:     "pkg/analyzer/testdata/src/a/tls/signaturescheme.go",
 		},
+		{
+			mapping:      mapping.ConstantKind,
+			packageName:  "constant_test",
+			templateName: "test-template.go.tmpl",
+			fileName:     "pkg/analyzer/testdata/src/a/constant/kind.go",
+		},
 	}
 
 	for _, operation := range operations {

pkg/analyzer/internal/mapping/mapping.go

@@ -4,6 +4,7 @@ import (
 	"crypto"
 	"crypto/tls"
 	"database/sql"
+	"go/constant"
 	"net/http"
 	"net/rpc"
 	"os"
@@ -192,3 +193,12 @@ var TLSSignatureScheme = map[string]string{
 	tls.PKCS1WithSHA1.String():          "tls.PKCS1WithSHA1.String()",
 	tls.ECDSAWithSHA1.String():          "tls.ECDSAWithSHA1.String()",
 }
+
+var ConstantKind = map[string]string{
+	// constant.Unknown.String(): "constant.Unknown.String()",
+	constant.Bool.String():    "constant.Bool.String()",
+	constant.String.String():  "constant..String()",
+	constant.Int.String():     "constant..String()",
+	constant.Float.String():   "constant..String()",
+	constant.Complex.String(): "constant..String()",
+}