Merge pull request #49 from sashamelentyev/feat/redirect-handler

feat: add check status code in http.RedirectHandler
sashamelentyev · Aug 15, 2022 · 40aae56 · 40aae56
2 parents 7c6dfe6 + 407243e
commit 40aae56
Show file tree

Hide file tree

Showing 3 changed files with 517 additions and 0 deletions.
diff --git a/pkg/analyzer/analyzer.go b/pkg/analyzer/analyzer.go
@@ -116,6 +116,15 @@ func run(pass *analysis.Pass) (interface{}, error) {
 					if basicLit := getBasicLitFromArgs(n.Args, 4, 3, token.INT); basicLit != nil {
 						checkHTTPStatusCode(pass, basicLit)
 					}
+
+				case "RedirectHandler":
+					if !lookupFlag(pass, HTTPStatusCodeFlag) {
+						return
+					}
+
+					if basicLit := getBasicLitFromArgs(n.Args, 2, 1, token.INT); basicLit != nil {
+						checkHTTPStatusCode(pass, basicLit)
+					}
 				}
 			default:
 				if selectorExpr.Sel.Name == "WriteHeader" {

diff --git a/pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl b/pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl
@@ -114,3 +114,15 @@ func _() {
     http.Redirect(w, r, "", {{ $value }})
 }
 {{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    http.RedirectHandler("", {{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+}
+{{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    http.RedirectHandler("", {{ $value }})
+}
+{{ end -}}