Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Auto-configure serverType and appLoc in sasjs web #1312

Merged
merged 3 commits into from
Jan 24, 2023
Merged

feat: Auto-configure serverType and appLoc in sasjs web #1312

merged 3 commits into from
Jan 24, 2023

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Jan 18, 2023 •
edited
Loading

Issue

closes #1183

Intent

  • Auto-configure serverType and appLoc in sasjs web

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@allanbowe allanbowe merged commit 47ae1fd into main Jan 24, 2023
@allanbowe allanbowe deleted the issue-1183 branch January 24, 2023 12:03
@sasjsbot
Copy link

🎉 This PR is included in version 3.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sabhas sabhas mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@medjedovicm medjedovicm medjedovicm approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-configure serverType and appLoc in sasjs web
4 participants
@sabhas @sasjsbot @allanbowe @medjedovicm