Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppLoc for global targets, code style checks in CI builds #136

Merged
merged 6 commits into from Oct 4, 2020
Merged

AppLoc for global targets, code style checks in CI builds #136

merged 6 commits into from Oct 4, 2020

Conversation

krishna-acondy
Copy link
Contributor

Issue

Intent

  • Allow users to specify an appLoc when adding a target to the global .sasjsrc file.
  • Check code style as part of CI builds

Implementation

  • Removed check that allows appLoc only for local targets.
  • Added lint script and added build step to run it.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested
    Unit test was unable to be added as it is currently impossible to mock two functions from the same module if they call each other. How to mock specific module function? jestjs/jest#936
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.

@krishna-acondy krishna-acondy changed the title Global target apploc AppLoc for global targets, code style checks in CI builds Oct 4, 2020
@allanbowe allanbowe merged commit ac5b007 into main Oct 4, 2020
@allanbowe allanbowe deleted the global-target-apploc branch October 4, 2020 18:05
@krishna-acondy
Copy link
Contributor Author

🎉 This PR is included in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@YuryShkoda YuryShkoda Awaiting requested review from YuryShkoda

@medjedovicm medjedovicm Awaiting requested review from medjedovicm

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI build does not check code style sasjs add should include apploc for global targets
2 participants
@krishna-acondy @allanbowe