Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable embedded blanks in mp_cleancsv, closes #289 #290

Merged
merged 1 commit into from Jul 21, 2022
Merged

fix: enable embedded blanks in mp_cleancsv, closes #289 #290

merged 1 commit into from Jul 21, 2022

Conversation

allanbowe
Copy link
Member

@allanbowe allanbowe commented Jul 21, 2022 •
edited

Issue

#289

Intent

Ensure that lines with blank rows for CR-formatted files are correctly converted to CRLF

Implementation

Made use of a goto statement (seemed appropriate in this context)

Checks

  • Code is formatted correctly (sasjs lint).
  • Any new functionality has been unit tested.
  • All unit tests are passing (sasjs test).

image

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2022

@allanbowe allanbowe merged commit 6a090e4 into main Jul 21, 2022
@allanbowe allanbowe deleted the allanbowe/mp-cleancsv-does-not-289 branch July 21, 2022 22:47
@krishna-acondy
Copy link
Contributor

🎉 This PR is included in version 4.34.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allanbowe @krishna-acondy