Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do the @ComponentScan on ApplicationContext#start #27

Closed
saskodh opened this issue Jul 17, 2016 · 1 comment · Fixed by #41
Closed

Do the @ComponentScan on ApplicationContext#start #27

saskodh opened this issue Jul 17, 2016 · 1 comment · Fixed by #41
Assignees
@damjangelovski

Comments

@saskodh
Copy link
Owner

saskodh commented Jul 17, 2016 •
edited by damjangelovski
Loading

Background

Currently the component scanning is implemented in the decorator and it runs immediately when the configuration class is loaded. We would like to replace that with lazy loading that is done when the configuration class is used to start an ApplicationContext.

Task

Make the @ComponentScan-ining lazy loading the components constructors on ApplicationContext startup. Make sure that other decorators used together with @componentscan work well with that. Example: @import, @propertysource..
Note: @propertysource should also lazy load the properties file. (Pass the file path instead of the actual file).
@damjangelovski damjangelovski self-assigned this Jul 21, 2016
damjangelovski added a commit that referenced this issue Jul 22, 2016
@damjangelovski
[#27] Do the @componentscan on ApplicationContext#start
2976979 
- initial implementation
damjangelovski added a commit that referenced this issue Jul 25, 2016
@damjangelovski
[#27] Do the @componentscan on ApplicationContext#start
db4efee 
- added ConfigurationUtil.isConfigurationClass
-  added logic for loading components and properties in ComponentData
 - added PropertySourceUtil
 - adjusted existing tests accordingly
 [work-in-progress]
 [reviewed by @saskodh and @draganAndonovski]
@damjangelovski damjangelovski mentioned this issue Jul 25, 2016
Merged
damjangelovski added a commit to saskodh/framework-showcase that referenced this issue Jul 25, 2016
@damjangelovski
[no-issue] Updated @propertysource() to lazy load the properties
b4daff9 
- Feature provided within this issue saskodh/framework#27
[reviewed by @saskodh and @draganAndonovski]
@damjangelovski
Copy link
Collaborator

Fix TODOs for adding missing unit tests in ComponentScanUtil

damjangelovski added a commit that referenced this issue Jul 26, 2016
@damjangelovski
[#27] Do the @componentscan on ApplicationContext#start
c8001a2 
- added RequireUtils
- fixed previosly added todos on the tests
[reviewed by @saskodh]
damjangelovski added a commit that referenced this issue Jul 26, 2016
@damjangelovski
Merge pull request #42 from saskodh/FR#27_component_scan
a07c90a 
[#27] Do the @componentscan on ApplicationContext#start
@saskodh saskodh mentioned this issue Aug 3, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damjangelovski damjangelovski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fr#27 component scan saskodh/framework
2 participants
@saskodh @damjangelovski