Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gird is Components? #22

Closed
torounit opened this issue Jan 31, 2016 · 1 comment
Closed

Gird is Components? #22

torounit opened this issue Jan 31, 2016 · 1 comment

Comments

@torounit
Copy link
Contributor

https://github.com/hiloki/flocss
フレームワークとして提供するなら、コンポーネントレイヤーにした方が良いと思う。
「ProjectレイヤーがComponentレイヤーのモジュールを変更すること」のみが許可されているので。
torounit added a commit to torounit/basis that referenced this issue Jan 31, 2016
@torounit
sass-basis#22 move and rename grid.
017870d
@inc2734
Copy link
Member

inc2734 commented Jan 31, 2016

FLOCSS のページにも

これらをクラスとして扱う場合には、それらは Object/Componentレイヤーとして定義させるほうが、多くのレイアウト、グリッドフレームワークをFLOCSSに適用させやすいと考えています。

とありますね。グリッドシステムのクラスにも c- がつくのは何となくイヤなのですが、そのほうが良さそうなのであれば移したほうが良いですかね

inc2734 added a commit that referenced this issue Jan 31, 2016
@inc2734
Merge pull request #23 from torounit/issues/#22
92bdf55 
#22 move and rename grid.
torounit added a commit to torounit/basis that referenced this issue Jan 31, 2016
@torounit
fix readme. sass-basis#22
4d0303f
inc2734 added a commit that referenced this issue Jan 31, 2016
@inc2734
Merge pull request #24 from torounit/hotfix/fix-readme
25a90d9 
fix readme. #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inc2734 @torounit