You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The additions to Eyeglass' .travis.yml file seem to allow deasync to build fine. Which means Travis test for Eyeglass on Node.js should be failing but isn't because of those extras.
However, if you include Eyeglass as a dependency (or devDependency) on a package.json, that projects Travis tests will fail.
Steps to reproduce:
Create an empty GitHub repo and add a package.json and .travis.yml file:
Enable Travis tests
Watch the install fail on deasync with:
../../nan/nan.h:43:3: error: #error This version of node/NAN/v8 requires a C++11 compiler
This install failure doesn't happen on Travis for Node.js 5 or earlier.
package.json:
Example repo: https://github.com/JohnAlbin/node-6-eyeglass-test
Actual Travis failure: https://travis-ci.org/JohnAlbin/node-6-eyeglass-test/builds/126856841
The text was updated successfully, but these errors were encountered:
It looks like deasync fails to build on Node.js.
The additions to Eyeglass' .travis.yml file seem to allow deasync to build fine. Which means Travis test for Eyeglass on Node.js should be failing but isn't because of those extras.
However, if you include Eyeglass as a dependency (or devDependency) on a package.json, that projects Travis tests will fail.
Steps to reproduce:
{
"name": "node-6-eyeglass-test",
"version": "1.0.1",
"description": "Test to see if Eyeglass installs under Node.js 6.'",
"main": "index.js",
"scripts": {
"test": "echo "Error: no test specified" && exit 0"
},
"repository": {
"type": "git",
"url": "https://github.com/JohnAlbin/node-6-eyeglass-test.git"
},
"author": "John Albin Wilkins virtually.johnalbin@gmail.com (http://john.albin.net/)",
"license": "GPL-2.0",
"bugs": {
"url": "https://github.com/JohnAlbin/node-6-eyeglass-test/issues"
},
"homepage": "https://github.com/JohnAlbin/node-6-eyeglass-test#readme",
"dependencies": {
"eyeglass": "^0.8.3"
}
}
sudo: false
language: node_js
node_js:
script: npm test
The text was updated successfully, but these errors were encountered: