Throw an error if the first error to selector.nest() contains & (#1068)

Closes #966
sass · Sep 3, 2020 · 4c0bc7f · 4c0bc7f
1 parent 330d93c
commit 4c0bc7f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## 1.26.11
 
+* **Potentially breaking bug fix:** `selector.nest()` now throws an error
+  if the first arguments contains the parent selector `&`.
+
 * Fixes a parsing bug with inline comments in selectors.
 
 * Improve some error messages for edge-case parse failures.

diff --git a/lib/src/functions/selector.dart b/lib/src/functions/selector.dart
@@ -44,8 +44,13 @@ final _nest = _function("nest", r"$selectors...", (arguments) {
         "\$selectors: At least one selector must be passed.");
   }
 
+  var first = true;
   return selectors
-      .map((selector) => selector.assertSelector(allowParent: true))
+      .map((selector) {
+        var result = selector.assertSelector(allowParent: !first);
+        first = false;
+        return result;
+      })
       .reduce((parent, child) => child.resolveParentSelectors(parent))
       .asSassList;
 });