Use implementation name dart-sass for VersionResponse (#2156)

Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
sass · Jan 16, 2024 · b263a72 · b263a72
1 parent 006baa5
commit b263a72
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 1.69.8
+
+### Embedded Sass
+
+* The Dart Sass embedded compiler now reports its name as "dart-sass" rather
+  than "Dart Sass", to match the JS API's `info` field.
+
 ## 1.69.7
 
 ### Embedded Sass

diff --git a/lib/src/embedded/isolate_dispatcher.dart b/lib/src/embedded/isolate_dispatcher.dart
@@ -137,7 +137,7 @@ class IsolateDispatcher {
       ..protocolVersion = const String.fromEnvironment("protocol-version")
       ..compilerVersion = const String.fromEnvironment("compiler-version")
       ..implementationVersion = const String.fromEnvironment("compiler-version")
-      ..implementationName = "Dart Sass";
+      ..implementationName = "dart-sass";
   }
 
   /// Handles an error thrown by the dispatcher or code it dispatches to.

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.69.7
+version: 1.69.8-dev
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass
 

diff --git a/test/embedded/protocol_test.dart b/test/embedded/protocol_test.dart
@@ -96,7 +96,7 @@ void main() {
     Version.parse(response.protocolVersion); // shouldn't throw
     Version.parse(response.compilerVersion); // shouldn't throw
     Version.parse(response.implementationVersion); // shouldn't throw
-    expect(response.implementationName, equals("Dart Sass"));
+    expect(response.implementationName, equals("dart-sass"));
     await process.close();
   });