Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect / no reference in CONTRIBUTING.md #1017

Closed
albert-github opened this issue May 29, 2020 · 1 comment · Fixed by #1018
Closed

Incorrect / no reference in CONTRIBUTING.md #1017

albert-github opened this issue May 29, 2020 · 1 comment · Fixed by #1018
Labels

Comments

@albert-github
Copy link

In the file CONTRIBUTING.md we see the output:

Changing the Node API

Most of Dart Sass's code is shared between Dart and Node.js, but the API that's exported by the sass npm package is Node-specific. It's defined using Dart's [JS interop package][], and it's tested by compiling the Dart package to JS and loading that JS using JS interop to best simulate the conditions under which it will be used in the real world.

The "strange" part is [JS interop package][] on line 164, so I suspect that something is missing here. Most likely it should read [JS interop package][JS]

@Awjin Awjin added the bug label May 29, 2020
@Awjin
Copy link
Contributor

Awjin commented May 29, 2020

Good eye, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants