Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math.div recommendation error #1356

Closed
jakewhiteley opened this issue Jun 13, 2021 · 0 comments · Fixed by #1358
Closed

math.div recommendation error #1356

jakewhiteley opened this issue Jun 13, 2021 · 0 comments · Fixed by #1358
Assignees
Labels

Comments

@jakewhiteley
Copy link

Version: 1.34.1

Here is a recommendation I just received:

   ╷
21 │         $value: 100 / (grid.$grid-columns / $i);
   │                        ^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    scss\utilities\_offset.scss 21:18                        @content
    scss\utilities\tools\mixins\_with-breakpoints.scss 18:2  with-breakpoints()
    scss\utilities\_offset.scss 13:1                         @forward
    scss\utilities\_index.scss 23:1                          @use
    test\assets\scss\style.scss 8:1                          root stylesheet

: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100, $grid.grid-columns / $i)

If the recommendation is followed, then the code will fail as it has incorrectly reported grid.$grid-columns as $grid.grid-columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants