Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSpan does not fullfill documented API interface #1790

Closed
loilo opened this issue Aug 28, 2022 · 0 comments · Fixed by #1801
Closed

MultiSpan does not fullfill documented API interface #1790

loilo opened this issue Aug 28, 2022 · 0 comments · Fixed by #1801
Assignees
Labels
bug JavaScript Issues particular to the Node.js distribution

Comments

@loilo
Copy link

loilo commented Aug 28, 2022

The MultiSpan introduced in Sass 1.54.0 does not provide access to the properties documented for SourceSpan. Although it looks like the properties should be accessible (I can only take a guess here because I don't know Dart), they are undefined in the JavaScript API.

Minimal Node.js code for reproducing the problem (tested with latest Sass version, 1.54.5):

let sass = require('sass')

sass.compileString(`* > { --foo: bar }`, {
  logger: {
    warn(_message, { span }) {
      // `span.start` should yield a `SourceLocation` according to documentation, gets `undefined` instead
      console.log(span.start)
    }
  }
})
@jathak jathak added bug JavaScript Issues particular to the Node.js distribution labels Sep 6, 2022
jathak added a commit that referenced this issue Sep 14, 2022
jathak added a commit that referenced this issue Sep 14, 2022
jathak added a commit that referenced this issue Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug JavaScript Issues particular to the Node.js distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants