Crash on float with leading sign but with no decimal

[connorskees]

dart-sass will crash on the following input:

a {
    color: +.;
}

a {
    color: -.;
}

Stacktrace

Unexpected exception:
FormatException: Invalid double
+


dart:core                                                double.parse
package:sass/src/parse/stylesheet.dart 2543              StylesheetParser._number
package:sass/src/parse/stylesheet.dart 2473              StylesheetParser._plusExpression
package:sass/src/parse/stylesheet.dart 2221              StylesheetParser._singleExpression
package:sass/src/parse/stylesheet.dart 1754              StylesheetParser._expression
package:sass/src/parse/stylesheet.dart 406               StylesheetParser._declarationOrBuffer
package:sass/src/parse/stylesheet.dart 322               StylesheetParser._declarationOrStyleRule
package:sass/src/parse/stylesheet.dart 189               StylesheetParser._statement
package:sass/src/parse/scss.dart 99                      ScssParser.children
package:sass/src/parse/stylesheet.dart 3906              StylesheetParser._withChildren
package:sass/src/parse/stylesheet.dart 490               StylesheetParser._styleRule
package:sass/src/parse/stylesheet.dart 275               StylesheetParser._variableDeclarationOrStyleRule
package:sass/src/parse/stylesheet.dart 190               StylesheetParser._statement
package:sass/src/parse/stylesheet.dart 91                StylesheetParser.parse.<fn>.<fn>
package:sass/src/parse/scss.dart 137                     ScssParser.statements
package:sass/src/parse/stylesheet.dart 82                StylesheetParser.parse.<fn>
package:sass/src/parse/parser.dart 713                   Parser.wrapSpanFormatException
package:sass/src/parse/stylesheet.dart 78                StylesheetParser.parse
package:sass/src/ast/sass/statement/stylesheet.dart 107  new Stylesheet.parseScss
package:sass/src/ast/sass/statement/stylesheet.dart 83   new Stylesheet.parse
package:sass/src/import_cache.dart 206                   ImportCache.importCanonical.<fn>
dart:collection                                          _LinkedHashMapMixin.putIfAbsent
package:sass/src/import_cache.dart 201                   ImportCache.importCanonical
package:sass/src/compile.dart 59                         compile
package:sass/src/executable/compile_stylesheet.dart 97   compileStylesheet
d:\a\dart-sass\dart-sass\bin\sass.dart 65                main

[nex3]

Apparently this is still an issue.

[nex3]

I went to add more tests for this, and the cases @stof mentioned (+1. and -1.) both throw useful errors as expected, so I'm going to close this back out pending a reproduction.

[connorskees]

I believe the issue as described by @stof is not that the inputs cause a crash, but rather that they now are no longer parsed as valid numbers.

[nex3]

I don't think they were ever parsed as valid numbers (I just tested on 1.57.1). Certainly per spec they oughtn't.

[connorskees]

Ah. Testing with sassmeister, you're right -- they've never been accepted as valid numbers. In which case I think there's no issue with #1865.