Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sass parses two SilentComment separated by two newlines as one #1941

Closed
tbondwilkinson opened this issue Apr 20, 2023 · 0 comments · Fixed by #1945
Closed

Sass parses two SilentComment separated by two newlines as one #1941

tbondwilkinson opened this issue Apr 20, 2023 · 0 comments · Fixed by #1945
Assignees
@nex3
Labels
AST API Issues about the sass_api Dart package bug

Comments

@tbondwilkinson
Copy link

The following is incorrectly parsed:

// First comment

// Second comment
foo {}

It should be parsed as two separate comments, but is currently parsed as one.
@nex3 nex3 added bug AST API Issues about the sass_api Dart package labels Apr 20, 2023
@nex3 nex3 self-assigned this Apr 25, 2023
@nex3 nex3 mentioned this issue Apr 25, 2023
Merged
nex3 added a commit that referenced this issue Apr 25, 2023
@nex3
Split SilentComment nodes on empty lines in SCSS
985a0ad 
Closes #1941
nex3 added a commit that referenced this issue Apr 25, 2023
@nex3
Split SilentComment nodes on empty lines in SCSS (#1945)
8dddcb7 
Closes #1941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
AST API Issues about the sass_api Dart package bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split SilentComment nodes on empty lines in SCSS sass/dart-sass
2 participants
@nex3 @tbondwilkinson