Implement Index and a default file if directory given in import

[john681611]

Ref to: sass/sass#2456

I've not done Dart before so any help will be accepted.

• Signed Contributors (waiting for legal to approve)
• Rebase and remove extra commits

See sass/sass-spec#1206

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[nex3]

Looking good! There's one behavioral change I'd like to see, though.

[nex3]

I think a .scss or .sass extension in the import should preclude looking for an index file.

[nex3]

Index file support is more a part of the language than the API; it's an aspect of what it means for a filesystem import will mean. Which is to say, I think the sass-spec tests are sufficient and we don't need implementation-specific tests like this.

[nex3]

Looks good! Just waiting on the other PRs and the CLA signature.

[john681611]

I signed it!

[nex3]

It looks like the CLA bot can't find your signature... is it associated with your GitHub account and the email you used for these commits?

[john681611]

Ah bugger I was advised to sign with my work email which is the secondary email in GitHub

[nex3]

If you run git --filter-branch --env-filter "GIT_AUTHOR_EMAIL=$WorkEmail; GIT_COMMITTER_EMAIL=$WorkEmail" origin/master; git push -f that should update the email and make the CLA bot happy.

[john681611]

I signed it!

[nex3]

I'm still not seeing that email in the list of signers... I'm going to contact internal support to see if I can get this sorted out. Sorry for the trouble!

[nex3]

Sounds like we just have to wait a couple days for the lawyers to approve Marks & Spencer's paperwork.

[john681611]

No worries. Its the first time I or M&S have contributed to any big open source project AFAIK

[john681611]

I signed it!

Hoping it worked this time 🤞

[nex3]

Looks like not yet 😕. I've poked the internal folks again.

[john681611]

Yeah, it keeps getting rejected saying our executive isn't high enough Head of Engineering just got rejected. We are working with our UK Google contact to figure out how high we have to go.

[john681611]

I signed it!

[nex3]

I do see the CLA internally now, but apparently googlebot still isn't happy? I'm not sure what's going on...

I'm sorry this process is being such a pain 😭. I really appreciate you sticking it out.

[john681611]

Can you force skip the bot?

[nex3]

Unfortunately, I can't. I've reached out to the internal team again to see if there's something else you need to do.

[john681611]

I signed it!

[googlebot]

CLAs look good, thanks!

[nex3]