Implement Index a default file #2456
Conversation
|
Thanks for the contribution! Because we're in the process of deprecating Ruby Sass, we aren't currently adding new features to Ruby only. If you're willing to add this behavior to Dart Sass as well and add cross-platform tests to sass-spec, then we can land it in both places at once. |
|
Ok I've got zero experience in dart so I will have a go |
|
Give it a shot! Dart is pretty easy to learn. |
|
Same comments as on the Dart PR: if the import ends in |
lib/sass/importers/filesystem.rb
Outdated
| @@ -154,7 +154,9 @@ def find_real_file(dir, name, options) | |||
| [Sass::Util.cleanpath(full_path).to_s, s] | |||
| end | |||
| end.flatten(1) | |||
| return if found.empty? | |||
| if found.empty? && _extension?(name) && File.directory?("#{dir}/#{name}") | |||
There was a problem hiding this comment.
I don't understand what _extension?(name) is doing here... are we only checking for an index file if name has an extension? That seems wrong.
There was a problem hiding this comment.
We figured it would be more readable than split(name)[2].nil? I'll switch back
There was a problem hiding this comment.
I meant more "why do we need to check for an extension at all" than "why is it factored out into a private method"
There was a problem hiding this comment.
Because of your above comment that if it has an extension in the name we shouldn't look at all.
There was a problem hiding this comment.
I just meant a .sass or .scss extension. If we disallow any extension, this spec will fail (and in fact I'm not sure why it isn't failing already...)
There was a problem hiding this comment.
Oh, sorry, I was being dumb here... I didn't realize that this was using the split() method defined below that already checks for the correct file extensions. Your original code was fine; I'll revert b196d9c.
This reverts commit b196d9c. This wasn't necessary, I just misunderstood the existing behavior.
[skip ci]
[skip ci]
|
Any info on when this feature might be released? |
|
I believe its released in https://sass-lang.com/dart-sass, ruby-sass is being deprecated so I'd look into moving to that. |
|
This was released as part of Ruby Sass 3.6.0. |
Something I have been wondering is did this make it into lib-sass or is that another separate piece of work I need to do? Basically, we need a web pack sass-loader that supports dart-sass and does de-duping. |
It looks like this landed in sass/libsass#2614.
The Webpack Sass loader support Dart Sass now. You just need to pass |
Attempting to fix #690
Simple implementation that if no file in current level is found it looks if it's a directory and searches for a valid index file inside.
Though I have the tests working I am unsure of how to run the code locally in a manual test.
Working with:
@liamshaunsmith
@mariann013
See sass/sass-spec#1206