Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let last !default value of @forward...with be commaless. #1226

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

Awjin
Copy link
Contributor

@Awjin Awjin commented Feb 4, 2021

This advances the scanner to the next line even if the !default
identifier is not followed by a comma.

Fixes #1222
See sass/sass-spec#1619

This advances the scanner to the next line even if the !default
identifier is not followed by a comma.
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry for this and make sure the pubspec is up-to-date?

@Awjin
Copy link
Contributor Author

Awjin commented Feb 4, 2021

Sure thing, added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces in @forward module configuration lead to parsing error
2 participants