Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose charset option in Node API [closes #567] #1446

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

adamhooper
Copy link
Contributor

My first commit -- please be gentle (and see #567 (comment) for rationale)

@nex3
Copy link
Contributor

nex3 commented Aug 23, 2021

Unfortunately, adding a new feature to the JS API isn't so simple. Because the JS API is shared between multiple implementations, you'll first need to introduce a proposal for the new feature in https://github.com/sass/sass, following this process. Only once that proposal is approved can we move on to the implementation phase.

@nex3 nex3 merged commit ad886d9 into sass:main Sep 2, 2021
@adamhooper adamhooper deleted the 567-node-charset branch September 2, 2021 13:52
@adamhooper
Copy link
Contributor Author

@nex3 Thank you for all your support and work on Sass! It feels awesome to be a part of it, however small :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants