Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for var() with an empty fallback argument #1723

Merged
merged 1 commit into from Jun 21, 2022
Merged

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 16, 2022

@nex3 nex3 merged commit c5e1f0b into main Jun 21, 2022
38 checks passed
@nex3 nex3 deleted the empty-fallback-var branch Jun 21, 2022
@@ -1688,7 +1702,7 @@ abstract class StylesheetParser extends Parser {
/// still be a valid expression. When it returns `true`, this returns the
/// expression.
@protected
Copy link
Contributor

@stof stof Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't @protected is removed here ? This method is now private

@@ -2141,7 +2155,7 @@ abstract class StylesheetParser extends Parser {
///
/// If [singleEquals] is true, this will allow the Microsoft-style `=`
/// operator at the top level.
Expression _expressionUntilComma({bool singleEquals = false}) => expression(
Expression expressionUntilComma({bool singleEquals = false}) => _expression(
Copy link
Contributor

@stof stof Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't @protected be added on this method now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants