Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing usage when no args provided #1963

Merged
merged 2 commits into from
May 16, 2023
Merged

Fix printing usage when no args provided #1963

merged 2 commits into from
May 16, 2023

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented May 16, 2023 •
edited

This PR fixes the following exception when running sass without any arguments:

Unhandled exception:
RangeError (index): Invalid value: Valid value range is empty: 0
#0      _Array.[] (dart:core-patch/array.dart:10)
#1      main (file:///Users/ntkme/Developer/dart-sass/bin/sass.dart:44)
#2      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:294)
#3      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189)

@nex3 nex3 merged commit 4692841 into sass:main May 16, 2023
43 checks passed
@ntkme ntkme deleted the fix-usage branch May 16, 2023 20:48
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request May 18, 2023
@jgerigmeyer
Merge branch 'main' into browser
e4fa5aa 
* main:
  Use the embedded protocol from the Sass language repo (sass#1966)
  Format with dart 3.0.1 (sass#1967)
  Pull more repeated GH Action tasks into sub-actions (sass#1964)
  Fix printing usage when no args provided (sass#1963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ntkme @nex3