Don't canonicalize file case in source maps #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding tests first, without implementation, to verify that they fail on Windows and thus that the fix actually does something. |
nex3
force-pushed
the
dont-canonicalize-case
branch
2 times, most recently
from
6ac1cb6
to
514b263
Compare
This will already have been canonicalized by the import process to whatever degree the importer deems necessary.
nex3
force-pushed
the
dont-canonicalize-case
branch
from
5e0bd7f
to
d9e99f8
Compare
nshahan
approved these changes
Jan 3, 2019
| @@ -27,7 +27,9 @@ class FilesystemImporter extends Importer { | |||
| ImporterResult load(Uri url) { | |||
| var path = p.fromUri(url); | |||
| return ImporterResult(io.readFile(path), | |||
| sourceMapUrl: url, syntax: Syntax.forPath(path)); | |||
| sourceMapUrl: | |||
| io.couldBeCaseInsensitive ? p.toUri(io.realCasePath(path)) : url, | |||
There was a problem hiding this comment.
Could omit this check here since realCasePath() makes a point to do the right thing. I guess this avoids converting to back to a uri from a string but it feels awkward.
There was a problem hiding this comment.
Yeah, efficiency is the goal here. URI parsing is probably dwarfed by file IO, but this importer is on a fairly hot path and little things can add up. I'll add a comment explaining why we're doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #540