Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FilesystemImport._loadPath absolute #651

Merged
merged 1 commit into from
Apr 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 1.18.1

### Dart API

* `FilesystemImporter` now doesn't change its effective directory if the working
directory changes, even if it's passed a relative argument.

## 1.18.0

* Avoid recursively listing directories when finding the canonical name of a
Expand Down
2 changes: 1 addition & 1 deletion lib/src/importer/filesystem.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class FilesystemImporter extends Importer {
final String _loadPath;

/// Creates an importer that loads files relative to [loadPath].
FilesystemImporter(this._loadPath);
FilesystemImporter(String loadPath) : _loadPath = p.absolute(loadPath);

Uri canonicalize(Uri url) {
if (url.scheme != 'file' && url.scheme != '') return null;
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.18.0
version: 1.18.1-dev
description: A Sass implementation in Dart.
author: Dart Team <misc@dartlang.org>
homepage: https://github.com/sass/dart-sass
Expand Down