Fix a bunch of small spec incompatibilities in built-in functions #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshahan
reviewed
Jul 3, 2019
| if (arguments[0] is SassNumber) { | ||
| if (weight.value != 100 || !weight.hasUnit("%")) { |
There was a problem hiding this comment.
Do these checks allow for calling the CSS function invert(70%);?
There was a problem hiding this comment.
Yes; weight here is the second argument, so as long as it's the default value, any number is allowed for the first argument.
| @@ -47,16 +47,20 @@ final global = UnmodifiableListView([ | |||
| } | |||
| }), | |||
|
|
|||
| BuiltInCallable("invert", r"$color, $weight: 50%", (arguments) { | |||
| BuiltInCallable("invert", r"$color, $weight: 100%", (arguments) { | |||
There was a problem hiding this comment.
Would you consider this a breaking change to alter the default value of weight?
There was a problem hiding this comment.
No, because previously this had a special case for $weight: 50% where it treated it as though the weight was 100% 😝. We removed that special case, but actually calling invert() with one argument still works the same as it always did.
nshahan
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass-spec#1424