Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import-only files for Node importers #919

Merged
merged 2 commits into from Jan 3, 2020
Merged

Fix import-only files for Node importers #919

merged 2 commits into from Jan 3, 2020

Conversation

@jathak
Copy link
Member

jathak commented Jan 3, 2020

No description provided.

@jathak jathak requested a review from nex3 Jan 3, 2020
@jathak jathak force-pushed the node-importer-fix branch from 3a84eef to 24e80ca Jan 3, 2020
@nex3
nex3 approved these changes Jan 3, 2020
Copy link
Contributor

nex3 left a comment

I feel silly for not adding these tests in the first place!

importer: allowInterop((void _, void __) =>
NodeImporterResult(file: p.join(sandbox, 'target.scss'))))),
equalsIgnoringWhitespace('a { b: regular; } a { b: import-only; }'));
});

This comment has been minimized.

Copy link
@nex3

nex3 Jan 3, 2020

Contributor

I'd also add a test to the top-level node_api_test that the default import logic supports both of these cases.

@jathak jathak merged commit bfdf4b3 into master Jan 3, 2020
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jathak jathak deleted the node-importer-fix branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.