Named arguments #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ruby functions to be called with keyword arguments.
… variable positional args.
* master: (23 commits) [Sass] Proper fix for sassGH-275 that doesn't break other tests. Closes sassGH-281. Revert "Disable rubyforge releasing until we get a project set up." Disable rubyforge releasing until we get a project set up. Watch for updates on port 3124. [Sass] Support --unix-newlines on Unix. [Sass] Properly detect SCSS with -c. Fix a typo. Clean up a few tests. Track the original filename of a sass file even within imports. We don't need to assume anything about cached root nodes anymore. Propagate Util.dump and Util.load through to child nodes and importers. [Emacs] Allow indentation beneath for loops. [Sass] Make color names csae-insensitive. [Sass] Add a changelog entry about aab0567. [Sass] Add an #invert function. [Sass] Clean up a little. Fix bug in compressed output of SCSS selectors with newlines. [Sass] Get rid of Compiler#forbid_update?. Allow objects that are not sass trees to be placed into the sass cache. Fixed one last reference to Sass::Files. ... Conflicts: test/sass/scss/scss_test.rb
* master: (23 commits) Fixed ruby 1.9.2 compatibility Bump VERSION to 3.0.21. Really fix the permissions errors. [Sass] Fix more #options bugs. Don't use Shellwords.shellescape. Revert "Set options on operands during Operation#perform." Bump VERSION to 3.0.20. [Sass] Make sure CSS function results get #options set. As part of packaging, fix up some permissions that can apparently go screwy. Set options on operands during Operation#perform. Bump VERSION to 3.0.19. [Sass] Remove spaces after commas in `:compressed` mode. [Haml] Fix interpolated if statements with HTML-escaping. [Haml] Fix engine_test for Ruby 1.8. [Haml] Properly dump encoded strings for the precompiled template. [Haml] Fix up a few more of the encoding assertions. [Haml] Fix an exception-swallowing bug. [Haml] Make encoding tests make a little more sense. [Haml] Fix encoding tests under Ruby 1.9.1. [Haml] Clean up the encoding tests. ... Conflicts: lib/sass/script/funcall.rb test/sass/engine_test.rb
|
I've started working on some modifications on my keyword-args branch. They aren't finished yet, though. |
|
Did this feature ever make it in? |
|
Yes. It's been in there since 3.1.0. |
|
Apologies, just saw it in the docs. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds named argument calling conventions to mixins and functions.