Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when source directory does not exist. Resolves #116. #119

Merged
merged 1 commit into from Feb 20, 2016
Merged

Error when source directory does not exist. Resolves #116. #119

merged 1 commit into from Feb 20, 2016

Conversation

asottile
Copy link
Member

@asottile asottile commented Feb 4, 2016

No description provided.

@asottile asottile mentioned this pull request Feb 4, 2016
Closed
dahlia
dahlia reviewed Feb 4, 2016
View reviewed changes
sasstests.py
@@ -846,6 +846,10 @@ def write_file(filename, contents):

class CompileDirectoriesTest(unittest.TestCase):

def test_directory_does_not_exist(self):
with self.assertRaises(OSError):
sass.compile(dirname=('i_dont_exist_lol', 'out'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs, use as a context manager of assertRaises() is introduced in Python 2.7. See also py26 build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah of course, I always forget this /me fixes

@asottile
Copy link
Member Author

asottile commented Feb 4, 2016

humm, seems mccabe 0.4.0 is not eggable in py35 on windows, @dahlia would you be opposed to abandoning python setup.py test and move to something like py.test sasstests.py ?

@dahlia
Copy link
Member

dahlia commented Feb 5, 2016

No problem. I personally prefer py.test over unittest.

On Fri, Feb 5, 2016, 7:01 AM Anthony Sottile notifications@github.com
wrote:

humm, seems mccabe 0.4.0 is not eggable in py35 on windows, @dahlia
https://github.com/dahlia would you be opposed to abandoning python
setup.py test and move to something like py.test sasstests.py ?

—
Reply to this email directly or view it on GitHub
#119 (comment)
.

asottile added a commit that referenced this pull request Feb 20, 2016
@asottile
Merge pull request #119 from asottile/raise_on_no_input_directory
ae0f92e 
Error when source directory does not exist.  Resolves #116.
@asottile asottile merged commit ae0f92e into sass:python Feb 20, 2016
@asottile asottile deleted the raise_on_no_input_directory branch February 20, 2016 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asottile @dahlia