Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should error when interpolating nothing #1093

Closed
xzyfer opened this issue Apr 11, 2015 · 3 comments · Fixed by #1180 or #1575
Closed

Should error when interpolating nothing #1093

xzyfer opened this issue Apr 11, 2015 · 3 comments · Fixed by #1180 or #1575

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Apr 11, 2015

These examples should produce the error show but do not

$foo: #{};

Should produce this error

Error: Invalid CSS after "$foo: #{": expected expression (e.g. 1px, bold), was "};"
        on line 1 of test.scss
  Use --trace for backtrace.

foo {
  bar: #{};
}

Should produce this error

Error: Invalid CSS after "  bar: #{": expected expression (e.g. 1px, bold), was "};"
        on line 2 of test.scss
  Use --trace for backtrace.

Specs added sass/sass-spec#324

@saper
Copy link
Member

saper commented Sep 20, 2015

assignment and property tests from sass/sass-spec#324 do not fail on libsass 3.3.0-beta2 (as they probably should).

@xzyfer
Copy link
Contributor Author

xzyfer commented Sep 21, 2015

Confirm this has regressed in 3.3

@xzyfer
Copy link
Contributor Author

xzyfer commented Sep 29, 2015

I have a fix for this. Will publish when I'm home.

@xzyfer xzyfer assigned xzyfer and unassigned mgreter Sep 29, 2015
@xzyfer xzyfer modified the milestone: 3.3 Sep 29, 2015
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment