Compilation and length issues for appended variable-length arglist

[davidkpiano]

Compilation runs forever with the below code:

@function foo($initial, $args...) {
    $args: append($args, 3);

    @return nth($args, 1);
}

@debug foo(1, 2);

// EXPECTED: 2

// ACTUAL (Ruby Sass v.3.4.13): 2
// ACTUAL (Node Sass v.3.0.0 and lower): << never finishes compiling, no output >>

Also, potentially related - an appended variable-length arglist should have an accurate length given by length()

@function foo($initial, $args...) {
    $args: append($args, 3);

    @return bar($initial, $args...);
}

@function bar($args...) {
    @debug $args; // DEBUG: 1, 2, 3 
                  // (in both node-sass and Ruby Sass)

    @return length($args);
}

@debug foo(1, 2);

// EXPECTED: 3

// ACTUAL (Ruby Sass v.3.4.13): 3
// ACTUAL (Node Sass v.3.0.0 and lower): 2

[xzyfer]

Spec added sass/sass-spec#364

[xzyfer]

@davidkpiano is this part of SassDash?

[davidkpiano]

@xzyfer Yep, _defaults() and _assign() (as well as other functions) rely on this behavior. 😄

[xzyfer]

Ok cool, prioritizing this to 3.2.3.

[mgreter]

First issue is covered by the PR. Maybe we should create a new issue for the second, since it is related to how we handle lists. IMO the second sample can probably be shortened down to:

foo {
  test-01: inspect(( (1, 2), (3, 4) ));
}

ruby sass:

foo {
  test-01: (1, 2), (3, 4); }

libsass:

foo {
  test-01: 1, 2, 3, 4; }

Seems like we join/flatten lists too often ...

[davidkpiano]

@mgreter Sure, want me to make a new issue with the second example? I feel like it might be an issue with arglists from variable-length arguments, rather than just lists (correct me if I'm wrong), hence the specific example.

[mgreter]

If you can confirm the first one is gone, sure! Close this one then and create a separate issue for the list append bug (which is caused by the sample I posted above, I'm very sure about that).

Ruby sass appends 3 to this list (1, 2), which results in (1, 2), 3, which has a length of 2.
Libsass appends 3 to the list 1, 2, which results in 1, 2, 3, which has a length of 3.
If I get your comments right, this has changed in ruby sass and we probably missed that!

[davidkpiano]

@mgreter Other way around. It seems that appending 3 to the arglist (1, 2) results in 1, 2, 3 for Ruby Sass and (1, 2), 3 for Libsass, or something like that.

[xzyfer]

This fix was a false positive due to sass/sass-spec#380. The spec still fails.

[davidkpiano]

😭

[xzyfer]

We're bummed as well. I've patched the test runner so there shouldn't be
anymore false positives.
On 14 May 2015 01:48, "David Khourshid" notifications@github.com wrote:

:(

—
Reply to this email directly or view it on GitHub
#1171 (comment).