Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be an error for named arguments in missing functions #1418

Closed
andrew-skybound opened this issue Jul 29, 2015 · 3 comments · Fixed by #1588
Closed

Should be an error for named arguments in missing functions #1418

andrew-skybound opened this issue Jul 29, 2015 · 3 comments · Fixed by #1588

Comments

@andrew-skybound
Copy link

Named arguments are not allowed in missing functions and an error should be raised. This includes functions invoked via call() when the function is not found.

Test Case 1:

p {
    color: missing($a: b);
}

Ruby SASS Output:

/* Error: Function missing doesn't support keyword arguments ...

Libsass Output:

p {
  color: missing($a: b);
}

Test Case 2:

p {
    color: call(missing, $a: b);
}

Ruby SASS Output:

/* Error: Function missing doesn't support keyword arguments ...

Libsass Output:

p {
  color: missing(b);
}
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Aug 4, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Aug 4, 2015

Spec added sass/sass-spec#463

@saper
Copy link
Member

saper commented Sep 20, 2015

A dynamic test from sass/sass-spec#463 shows this:

foo {
    color: call(missing, $a: b);
}

Output:

foo {
  color: missing(b); }

saper pushed a commit to saper/sass-spec that referenced this issue Sep 20, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Sep 21, 2015

Looks like the original patch never fixed the dynamic case.

@xzyfer xzyfer reopened this Sep 21, 2015
saper pushed a commit to saper/sass-spec that referenced this issue Sep 21, 2015
saper pushed a commit to saper/sass-spec that referenced this issue Sep 21, 2015
saper pushed a commit to saper/sass-spec that referenced this issue Sep 21, 2015
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 7, 2015
@xzyfer xzyfer assigned xzyfer and unassigned mgreter Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants