Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-DDEBUG should not add unconditional debug output #1518

Closed
Tracked by #1892
saper opened this issue Sep 2, 2015 · 4 comments
Closed
Tracked by #1892

-DDEBUG should not add unconditional debug output #1518

saper opened this issue Sep 2, 2015 · 4 comments

Comments

@saper
Copy link
Member

saper commented Sep 2, 2015

I have -DDEBUG in my compiler flags due to building of the debug module of node and it looks like libsass generates a lot of debugging output automatically.

There should be a runtime option to explicitly set the debug level (default: off) to keep libsass quiet by default.

saper added a commit to saper/node-sass that referenced this issue Sep 2, 2015
-DDEBUG currently causes libsass
to unconditionally produce debug
output which may break our tess.

Reported upstream as:

sass/libsass#1518
saper added a commit to saper/node-sass that referenced this issue Sep 2, 2015
-DDEBUG currently causes libsass
to unconditionally produce debug
output which may break our tess.

Reported upstream as:

sass/libsass#1518
@xzyfer xzyfer added the Build label Sep 4, 2015
saper added a commit to saper/node-sass that referenced this issue Sep 7, 2015
If compiling using the debug build of node
-DDEBUG and -D_DEBUG flags are automatically
added.

This causes libsass to produce additional
debugging output that may interfere with
tests.

Once this is resolved, this can be reverted.

Reported-as: sass/libsass#1518
saper added a commit to saper/node-sass that referenced this issue Sep 16, 2015
If compiling using the debug build of node
-DDEBUG and -D_DEBUG flags are automatically
added.

This causes libsass to produce additional
debugging output that may interfere with
tests.

Once this is resolved, this can be reverted.

Reported-as: sass/libsass#1518
@mgreter
Copy link
Contributor

mgreter commented Jan 22, 2016

Not sure if it is really that unreasonable for libsass to produce debug output when DEBUG compile flag is set. Each implementer that compiles libsass can set that option accordingly if desired. So I feel it's ok the way it is now, although a more sophisticated debug interface would be desirable (PR always welcome, but as such not a high prio).

I added this to the wish-list ticket, since I think this issue is actually more about a better and more configurable debug build itself. Currently the DEBUG flag only really debugs the extend step and nothing else ...

@mgreter mgreter closed this as completed Jan 22, 2016
@mgreter mgreter mentioned this issue Jan 22, 2016
12 tasks
@xzyfer
Copy link
Contributor

xzyfer commented Jan 22, 2016

I noticed this broke in 3.3.3. I use DEBUG_PRINTLN a lot. This made me sad.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 22, 2016

Maybe I'm misunderstanding, and this is not related to the DEBUG_LVL used by debug.hpp.

@mgreter
Copy link
Contributor

mgreter commented Jan 22, 2016

I guess it's related and it was unknown to me we already had something for starters in debug.hpp. But I'm still pretty sure this is only used in extend step, so only covers a small bit of what can be debugged (I mostly use debugger.hpp for "on demand" debugging).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants