Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the at-error feature flag #1011

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Add the at-error feature flag #1011

merged 1 commit into from
Mar 31, 2015

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Mar 31, 2015

This PR adds the at-error feature flag.

Spec added sass/sass-spec#292.

@xzyfer xzyfer added this to the 3.2 milestone Mar 31, 2015
@xzyfer xzyfer self-assigned this Mar 31, 2015
@mgreter
Copy link
Contributor

mgreter commented Mar 31, 2015

Why is it called at-root in the PR and at-error in the code/test ?

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 31, 2015

Yeah my bad :)

@xzyfer xzyfer changed the title Add the at-root feature flag Add the at-error feature flag Mar 31, 2015
@mgreter
Copy link
Contributor

mgreter commented Mar 31, 2015

OK, guess most important is the commit message :)

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 31, 2015

Haha the code was right which is the important part :) I've amended the commit message.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.09% when pulling e220e06 on xzyfer:feat/at-error-feature into 4ebec9a on sass:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.09% when pulling 170de9c on xzyfer:feat/at-error-feature into 4ebec9a on sass:master.

xzyfer added a commit that referenced this pull request Mar 31, 2015
@xzyfer
Merge pull request #1011 from xzyfer/feat/at-error-feature
fd98618 
Add the at-error feature flag
@xzyfer xzyfer merged commit fd98618 into sass:master Mar 31, 2015
@xzyfer xzyfer deleted the feat/at-error-feature branch March 31, 2015 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xzyfer xzyfer

Labels
Dev - Test Written Discussion - Proposal
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xzyfer @mgreter @coveralls