Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ie property and expression parsing #1194

Merged
merged 1 commit into from
May 12, 2015
Merged

Improve ie property and expression parsing #1194

merged 1 commit into from
May 12, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented May 10, 2015

Fixes #1188
Fixes #1107
Fixes #1102
Fixes #931

@mgreter mgreter self-assigned this May 10, 2015
@mgreter mgreter added this to the 3.2.4 milestone May 10, 2015
@mgreter mgreter force-pushed the bugfix/issue_1188 branch 2 times, most recently from b70825c to eedba4d Compare May 10, 2015 21:53
xzyfer
xzyfer reviewed May 11, 2015
View reviewed changes
util.cpp
text += i;
} else if (!inside_str && (i == '"' || i == '\'')) {
} else if (false && !inside_str && (i == '"' || i == '\'')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, seems valid, can be gone ...

@xzyfer xzyfer mentioned this pull request May 11, 2015
Merged
@xzyfer
Copy link
Contributor

xzyfer commented May 11, 2015

Spec PR sass/sass-spec#375

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.17%) to 80.02% when pulling cd18ae8 on mgreter:bugfix/issue_1188 into fb33a2a on sass:master.

@xzyfer
Copy link
Contributor

xzyfer commented May 12, 2015

👍

Also I wonder if parsing these ie expressions is worth the effort (and perf hit?). Could we get away with going back to treating these as String_Schemas?

xzyfer added a commit that referenced this pull request May 12, 2015
@xzyfer
Merge pull request #1194 from mgreter/bugfix/issue_1188
8ca8816 
Improve ie property and expression parsing
@xzyfer xzyfer merged commit 8ca8816 into sass:master May 12, 2015
@xzyfer xzyfer mentioned this pull request May 12, 2015
Closed
@mgreter mgreter deleted the bugfix/issue_1188 branch July 28, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.2.4
3 participants
@mgreter @xzyfer @coveralls