Improve url parsing (allow line-feeds)

[mgreter]

Fixes #1096

[xzyfer]

Should this be a sequence?

sequence< exactly <'\\'>, alternatives< exactly <'\r'>, exactly <'\n'> > >

[mgreter]

Do you really want to be that strict? Seems to work fine and not sure how ruby sass really does it ... this way it also accepts certain escape sequences (which I guess is correct). Feel free to create a more specific spec test ;)

[xzyfer]

As is stands I believe this would allow cases Ruby Sass does not, and that aren't in the CSS Spec (which is bad)

@import url("foo\
bar");
@import url("foo
bar");
@import url(foo
bar);
//Errors with Ruby Sass
@import url(foo\
bar);

Ruby Sass

@import url("foobar");
@import url("foo\a bar");
@import url(foo bar);

With this patch

@import url("foobar");
@import url("foo\abar");
@import url(foo
bar);
@import url(foobar);

[xzyfer]

Also, it looks like Ruby Sass treats the new line in the quoted string as a space delimited list.

[mgreter]

OK, I see you're point!

[xzyfer]

What does flag mean? Is there a better name that will describe what this is for?

[mgreter]

Didn't yet come around to look more into it. But it's the reason why I added WIP again. Again I don't really know if we need to move the code part that uses this flag to another function. Will have another look after work 😄

[xzyfer]

Ok cool. I'm just catching up trying to prepare for a new node-sass release.

[xzyfer]

Update the specs sass/sass-spec#374

[mgreter]

I renamed the flag to keep_linefeed_whitespace. I have no idea why ruby sass does what it does here. So I really can only describe what the flag is actually doing. It seems to be some discrepancy between interpolation, quoted string, strings to css or something else. And I'm out of clues and guesses.

[coveralls]

Coverage decreased (-0.02%) to 80.17% when pulling 258e8b7 on mgreter:bugfix/issue_1096 into fb33a2a on sass:master.

[xzyfer]

Are just handling url values poorly? The Ruby Sass behaviour seems intuitive to me.

If the url value is a quoted string and the newline is escaped then it's removed.
If the url value is not a quoted string it's a Sass list.

[xzyfer]

I noticed another thing

@import url("foo
bar");

Produces a deprecation warning in Ruby Sass

DEPRECATION WARNING on line 2, column 13 of test.scss:
Unescaped multiline strings are deprecated and will be removed in a future version of Sass.
To include a newline in a string, use "\a" or "\a " as in CSS.

@import url("foo\a bar");

But not Libsass

@import url("foo\a bar");

Libsass does however produce the deprecation warning if there is more content after the @import

@import url("foo
bar");
// foo

[xzyfer]

Given this new information it would seem I was incorrect in thinking Ruby turned multi-line strings into lists. It appears to native support multi-line strings but normalises the newline to a space in the output phase.

[coveralls]

Coverage decreased (-0.02%) to 80.1% when pulling 9b8545b on mgreter:bugfix/issue_1096 into 8ca8816 on sass:master.

[am11]

🎉
Thanks @mgreter! ,