Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement is_superselector sass function #1202

Merged
merged 2 commits into from
May 13, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented May 12, 2015

Based on #1064

This is mainly for me to try out is superselector behavior which is one root problem of our selector deduping issues (which covers pretty much all of the currently still open confirmed bug issues).
It may also be a base to get the work done by @onedayitwillmake merged into master for 3.3.

@mgreter
Copy link
Contributor Author

mgreter commented May 12, 2015

By sheer accident I seem to have fixed #823, #1063 and #1091 😀
Plus we pass a lot more of the is_superselector spec tests added in #963

IMO we should be able to include the improvements for 3.2.4, since they are clear bugfixes.
@xzyfer would you want to hold off the is_superselector function for 3.3!? I would ship it.

@mgreter mgreter force-pushed the feature/selector-functions-basic branch from ea659cd to ff3f8a0 Compare May 12, 2015 23:28
@xzyfer
Copy link
Contributor

xzyfer commented May 12, 2015

If you think it's ready we can ship it now. I'm keen to tag 3.2.4 in the
next hour or so.
On 13 May 2015 09:28, "Coveralls" notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/2548983

Coverage decreased (-0.15%) to 79.97% when pulling ea659cd
ea659cd
on mgreter:feature/selector-functions-basic
into 28ee088
28ee088
on sass:master
.


Reply to this email directly or view it on GitHub
#1202 (comment).

@mgreter
Copy link
Contributor Author

mgreter commented May 12, 2015

OK, just a few moments ... let me clean up some white-space and comments ...

@mgreter mgreter force-pushed the feature/selector-functions-basic branch from ff3f8a0 to f8074a0 Compare May 12, 2015 23:36
@mgreter
Copy link
Contributor Author

mgreter commented May 12, 2015

Also let's wait for CI here, then activate all spec tests and re-start the CI to check again ...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 80.11% when pulling ff3f8a0 on mgreter:feature/selector-functions-basic into 28ee088 on sass:master.

@xzyfer
Copy link
Contributor

xzyfer commented May 12, 2015

Great. I think there are some specs that need to be activated from the
recent PRs as well.
On 13 May 2015 09:39, "Coveralls" notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/2549041

Coverage decreased (-2.53%) to 77.59% when pulling ff3f8a0
ff3f8a0
on mgreter:feature/selector-functions-basic
into 28ee088
28ee088
on sass:master
.


Reply to this email directly or view it on GitHub
#1202 (comment).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.13%) to 80.25% when pulling f8074a0 on mgreter:feature/selector-functions-basic into 28ee088 on sass:master.

@mgreter
Copy link
Contributor Author

mgreter commented May 12, 2015

As always, I just create a big activate patch for the next release.
sass/sass-spec#379

@mgreter
Copy link
Contributor Author

mgreter commented May 12, 2015

Merged spec activation patch and restarting CI rebuild now ...

@mgreter mgreter added this to the 3.2.4 milestone May 12, 2015
@mgreter mgreter self-assigned this May 12, 2015
@mgreter mgreter changed the title Implement is_superselector sass function [RFC] [WIP] Implement is_superselector sass function May 13, 2015
mgreter added a commit that referenced this pull request May 13, 2015
Implement `is_superselector` sass function
@mgreter mgreter merged commit a6482aa into sass:master May 13, 2015
@mgreter mgreter deleted the feature/selector-functions-basic branch July 28, 2015 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants