Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two segfaults with parent selectors #1527

Merged
merged 1 commit into from
Sep 3, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Sep 3, 2015

Slightly tweaks the way we parse selectors in regard to
the parent selector. We only add one if we are not parsing
inside some root context (passed by boolean argument).

Fixes #1519

test-1

foo {
  @extend &;
}

test-2

& {}

test-3

& foo {
  bar: baz;
}

test-4

foo & {
  bar: baz;
}

@mgreter mgreter added this to the 3.3 milestone Sep 3, 2015
@mgreter mgreter force-pushed the bugfix/parent-selector-segfaults branch from e138854 to 4047bce Compare September 3, 2015 20:19
@mgreter mgreter force-pushed the bugfix/parent-selector-segfaults branch 2 times, most recently from 45deafe to 91f1d37 Compare September 3, 2015 21:15
Slightly tweaks the way we parse selectors in regard to
the parent selector. We only add one if we are not parsing
inside some root context (passed by boolean argument).
@mgreter mgreter force-pushed the bugfix/parent-selector-segfaults branch from 91f1d37 to 89adfaa Compare September 3, 2015 21:41
@mgreter mgreter mentioned this pull request Sep 3, 2015
@saper
Copy link
Member

saper commented Sep 3, 2015

Yes, thank you!

mgreter added a commit that referenced this pull request Sep 3, 2015
@mgreter mgreter merged commit b597681 into sass:master Sep 3, 2015
@mgreter mgreter deleted the bugfix/parent-selector-segfaults branch September 3, 2015 23:54
xzyfer added a commit to xzyfer/sass-spec that referenced this pull request Jan 12, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Jan 12, 2016

Specs added and activated in sass/sass-spec#689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants