More consistent deprecation warnings #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
feat/better-deprecation-warnings
branch
from
d6f4abb
to
49d6a6a
Compare
xzyfer
changed the title
xzyfer
added a commit
to xzyfer/sass-spec
that referenced
this pull request
Nov 2, 2015
This PR activates specs for sass/libsass#1681
xzyfer
changed the title
|
The algorithm I have for determining which path to show isn't perfect, but it's closer than it was and it makes sass-spec happy. I've opened sass/sass#1880 to help get us on the same page moving forward. |
xzyfer
added a commit
to xzyfer/sass-spec
that referenced
this pull request
Nov 2, 2015
This PR activates specs for sass/libsass#1681
This is actually even more complicated. The deprecation warning format in Ruby Sass is inconsistent which makes it difficult to match. These are the two commmon cases.
xzyfer
force-pushed
the
feat/better-deprecation-warnings
branch
from
49d6a6a
to
5be5128
Compare
xzyfer
added a commit
that referenced
this pull request
Nov 2, 2015
More consistent deprecation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation warning format in Ruby Sass is inconsistent which makes it difficult to
match. These are the two common cases. This PR addresses the two most common cases.
Spec sass/sass-spec#581