Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add an option for allowing the old .css import behaviour #1964

Closed
wants to merge 1 commit into from

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Mar 26, 2016

The broken behaviour was removed in #1963. There appears to be some support for this, although I'm very much against it. Additionally we have no way presently to test flags like this.

@mgreter
Copy link
Contributor

mgreter commented Apr 7, 2016

Looks quite ok too me, but instead of creating a specific option for another extension (.css) I would prefer to have the full std::vector<std::string> exposed as far as possible. This means bridging between C-API and C++ will be a bit more complicated. But we may can work with a similar apporach as with push_include_dir (IMO we don't need full manipulation support on the C side).
The C-API part would then look something like this:

sass_option_push_import_extension($options, "css");

This would be very close to ruby sass, as they also allow to alter the list of extensions it will try to resolve.

@mgreter mgreter added the C API label Apr 7, 2016
xzyfer added a commit to xzyfer/libsass that referenced this pull request Mar 24, 2018
This is big step towards removing non-standard raw css imports.

Using `sass_option_push_import_extension` implementors can choose
to treat any extension they like as a `.scss` file.

Closes sass#1964
xzyfer added a commit to xzyfer/libsass that referenced this pull request Mar 24, 2018
This is big step towards removing non-standard raw css imports.

Using `sass_option_push_import_extension` implementors can choose
to treat any extension they like as a `.scss` file.

Closes sass#1964
xzyfer added a commit to xzyfer/libsass that referenced this pull request Mar 24, 2018
This is big step towards removing non-standard raw css imports.

Using `sass_option_push_import_extension` implementors can choose
to treat any extension they like as a `.scss` file.

Closes sass#1964
xzyfer added a commit to xzyfer/libsass that referenced this pull request Mar 27, 2018
This is big step towards removing non-standard raw css imports.

Using `sass_option_push_import_extension` implementors can choose
to treat any extension they like as a `.scss` file.

Closes sass#1964
@xzyfer xzyfer closed this in #2615 Mar 28, 2018
xzyfer added a commit that referenced this pull request Mar 28, 2018
This is big step towards removing non-standard raw css imports.

Using `sass_option_push_import_extension` implementors can choose
to treat any extension they like as a `.scss` file.

Closes #1964
xzyfer added a commit that referenced this pull request Mar 30, 2018
This is big step towards removing non-standard raw css imports.

Using `sass_option_push_import_extension` implementors can choose
to treat any extension they like as a `.scss` file.

Closes #1964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants