[3.2] Implement @at-root #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently passing all the at-root specs. I'll do some clean but otherwise it's ready. |
xzyfer
force-pushed
the
feat/at-root
branch
3 times, most recently
from
8879cfe
to
34d6f55
Compare
| return exactly<without_kwd>(src); | ||
| } | ||
|
|
||
| const char* foo(const char* src) { |
xzyfer
force-pushed
the
feat/at-root
branch
5 times, most recently
from
a13dcbc
to
a674f97
Compare
|
I managed to rebase this post-sourcemaps-mega-merge with relatively little pain. I now have a failing at-root spec though. Once that's resolved I'll ship this. |
|
👍 Don't forget to check off any solved issues at #629 |
|
This is ready to go pending CI. I corrected some issues with nested output. |
|
Thanks for catching the output stuff @mgreter I amended that commit. That has also broken generic at-rule output (more than I expected). I was going to address at-rule bubbling and output in a different PR but I'll have to handle it here. |
xzyfer
force-pushed
the
feat/at-root
branch
3 times, most recently
from
f42dbcf
to
f3db16e
Compare
xzyfer
added a commit
that referenced
this pull request
Jan 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
@at-root.TODO
This feature is good to go.
Fixes #353. Specs added sass/sass-spec#175, sass/sass-spec#217, sass/sass-spec#219.
It turns out there were a lot of todo tests lying around addressing at-root. As a result the following specs now pass with this PR.