Remove the non-standard compact function #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any objections to shipping this? Please read the discussion in #834 |
|
Hmm... makes me think maybe we should as Sass if they will add this feature. But, remove it for now, as it's not covered in Sass. |
|
I believe variadic argument lists were supposed to make this function unnecessary. |
xzyfer
added a commit
that referenced
this pull request
Feb 16, 2015
Remove the non-standard compact function
This was referenced Feb 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the non-standard
compactfunction.This PR exhibits the same behaviour as #834 and will be adjusted to match the final decision made there.
Fixes #585.