Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /deep/ shadow DOM selector #994

Merged
merged 1 commit into from Mar 28, 2015
Merged

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Mar 28, 2015

Fixes #452 (spec-tests: sass/sass-spec#287)

@mgreter mgreter self-assigned this Mar 28, 2015
@mgreter mgreter added this to the 3.2 milestone Mar 28, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 80.38% when pulling 5caacc3 on mgreter:bugfix/issue_452 into ff3565b on sass:master.

mgreter added a commit that referenced this pull request Mar 28, 2015
Implement `/deep/` shadow DOM selector
@mgreter mgreter merged commit 091010d into sass:master Mar 28, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Mar 31, 2015

@mgreter I looked into this a while ago, it's much more involved than what has been done here.

For intents and purposes the /deep/ combinator acts like the direct sibling combinator except for the shadow dom. 3.2.4 Selecting Through Shadows: the /deep/ combinator.

Essentially /deep/ needs to be treated exactly the same as +.

This is a relevant specs - https://github.com/sass/sass-spec/blob/master/spec/libsass-todo-tests/scss-tests/175_test_reference_combinator_with_parent_ref/input.scss


Also /deep/ is a reference combinator as defined in CSS Selectors Level 4.

The reference combinator consists of two slashes with an intervening CSS qualified name, and separates two compound selectors, e.g. A /attr/ B.

We need to handle generic reference combinators, not just /deep/.

This is a relevant spec - https://github.com/sass/sass-spec/blob/master/spec/libsass-todo-tests/scss-tests/117_test_selector_interpolation_in_reference_combinator/input.scss

@mgreter mgreter deleted the bugfix/issue_452 branch April 6, 2015 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Shadow DOM styling
3 participants