Use a stable sort in Patch.applyAll #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Nov 5, 2019
lib/src/patch.dart
Outdated
| var sortedPatches = patches.toList() | ||
| ..sort((a, b) => a.selection.compareTo(b.selection)); | ||
| var sortedPatches = patches.toList(); | ||
| mergeSort(sortedPatches, |
There was a problem hiding this comment.
Add a comment here explaining why you're using mergeSort() over List.sort().
lib/src/patch.dart
Outdated
| ..sort((a, b) => a.selection.compareTo(b.selection)); | ||
| var sortedPatches = patches.toList(); | ||
| mergeSort(sortedPatches, | ||
| compare: (a, b) => a.selection.compareTo(b.selection)); |
There was a problem hiding this comment.
I don't think you need to pass this, I think calling compareTo() is the default behavior.
Patches can be order-dependent when insertion patches are involved, so we need to use a stable sort in Patch.applyAll.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches can be order-dependent when insertion patches are involved, so
we need to use a stable sort in Patch.applyAll.