Changes based on review for #4 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highlights: - The migrator now extends RecursiveStatementVisitor, eliminating the need for BaseVisitor - Migration state for each stylesheet is now stored in StylesheetMigration, which keeps track of member scope, namespaces, and patches. - The migrator now always runs on all dependencies, with the command-line options now only used to determine which migrations are written to disk. This simplifies the migrator logic. - Since dependencies are migrated at the time the import rule is migrated, the global members of the dependency are forwarded onto the StylesheetMigration, which allows the namespacing of implicit dependencies to avoid the complicated logic of examining the entire dependency graph each time. - The tests now use test_descriptor to avoid the need for mocks.
Closed
Previously, when adding a new use rule for an indirect reference to a member of a partial, the underscore would be removed from the rule's URL, but its namespace was calculated based on the full path.
nex3
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
the need for BaseVisitor
StylesheetMigration, which keeps track of member scope, namespaces,
and patches.
command-line options now only used to determine which migrations are
written to disk. This simplifies the migrator logic.
migrated, the global members of the dependency are forwarded onto the
StylesheetMigration, which allows the namespacing of implicit
dependencies to avoid the complicated logic of examining the entire
dependency graph each time.