Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Visual Studio 2013 no longer available for download #1838

Closed
cheapsteak opened this issue Dec 16, 2016 · 6 comments
Closed

Visual Studio 2013 no longer available for download #1838

cheapsteak opened this issue Dec 16, 2016 · 6 comments

Comments

@cheapsteak
Copy link

This link now only contains download for vs 2017:
https://www.visualstudio.com/downloads/download-visual-studio-vs#d-express-windows-desktop

Should the readme be updated?
What would be the method for building node-sass on windows now?

@nschonni
Copy link
Contributor

I think it should probibly point to the node-gyp instructions since that is really what we require https://github.com/nodejs/node-gyp#installation. That said I want to say there was an issue at one point with the optimizations in 2015 that didn't play nice with XP?

@saper
Copy link
Member

saper commented Dec 17, 2016

@nschonni the reason we insisted on vs2013 was that the official node builds were build with vs2013 at the time. Mixing C++ runtime libs across the module border is never guarantee to work. Our XP users got hit with some particular difference in the way a thread local storage got initialized.

@cheapsteak
Copy link
Author

What do you think about replacing it with this?
npm install --global --production windows-build-tools node-gyp

Referenced from node-gyp's instructions for windows, which references Microsofts' NodeJS Guidelines

@nschonni
Copy link
Contributor

Maybe a cleaned up version of this? https://github.com/laverdet/node-fibers#from-source
It's probably good to look around at some of the native packages and see how they explain it.

@xzyfer
Copy link
Contributor

xzyfer commented Dec 22, 2016

I'm all for recommending windows-build-tools over VS2013 if we can verify the compiled binary works as expected.

@saper
Copy link
Member

saper commented Dec 23, 2016

Good idea, we only need to check it can be cached (so we do not download it every time) and that my fancy PDB debugging support works :)

Friendly-users referenced this issue in Friendly-users/node-sass Jul 9, 2024
-----
It is inappropriate to include political and offensive content in public code repositories.

Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment.

Please refrain from adding such content to public code repositories.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants