Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention electron caveat in readme #2304

Open
burningTyger opened this issue Mar 22, 2018 · 2 comments
Open

mention electron caveat in readme #2304

burningTyger opened this issue Mar 22, 2018 · 2 comments

Comments

@burningTyger
Copy link

Neither bug nor feature just a friendly request to add a caveat to the readme that node-sass doesn't work in electron. Would have saved me a couple of hours of research since I never assumed to google the usual error message with electron in the search string. I was totally not expecting a connection since my app is vue component based and compiles just fine with node-sass (before running under electron though).

Thank you

  • NPM version (npm -v): -
  • Node version (node -v): -
  • Node Process (node -p process.versions): -
  • Node Platform (node -p process.platform): -
  • Node architecture (node -p process.arch): -
  • node-sass version (node -p "require('node-sass').info"): -
  • npm node-sass versions (npm ls node-sass): -
@saper saper self-assigned this Mar 23, 2018
@mubaidr
Copy link

mubaidr commented Apr 29, 2018

I don't think Electron has anything to do with this package. Your blunder script should be responsible to handle the sass files and compiles them to css to be able to load in browsers (or Electron.js)

I am using web-pack (similar to vue-cli generated project) to load vue app (containing sass) inside electron and it works fine.

Or maybe i misunderstood your question?

@saper
Copy link
Member

saper commented Apr 29, 2018

I think the problem is that people try to use electron node to run node-sass, which will not work. Yes, the generated CSS should be portable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants