Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative url paths #430

Closed
am11 opened this issue Sep 22, 2014 · 1 comment
Closed

Relative url paths #430

am11 opened this issue Sep 22, 2014 · 1 comment

Comments

@am11
Copy link
Contributor

am11 commented Sep 22, 2014

According to https://github.com/sass/node-sass#imagepath, whatever path is set to imagePath, it will be prepended to output for image-url(..), which is; url(..).

Now that we are sending outPath to downstream (so it handles sourceMaps related path correctly), shouldn't we make it practice to resolve image URLs w.r.t. generated CSS file location (so implementers don't have to post-process these using separate AST, like this)?

Reproduction steps: less/less.js#2084 (comment) (just replace less with scss).

@andrew, @mgreter,

@am11
Copy link
Contributor Author

am11 commented Oct 12, 2014

This issue has been moved to: sass/libsass#532.

@am11 am11 closed this as completed Oct 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant