Automatically add nice header linking behavior #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 9, 2019
| } | ||
|
|
||
| &:target { | ||
| animation-name: highlight-header; |
There was a problem hiding this comment.
Properties should be ordered animation-duration, animation-name
| } | ||
| } | ||
|
|
||
| &:hover a.anchor::after { |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
| a { | ||
| h1, h2, h3, h4, h5, h6 { | ||
| a.anchor { | ||
| display: block; |
There was a problem hiding this comment.
Properties should be ordered background, border, display, float, margin, vertical-align, width
|
|
||
| a { | ||
| h1, h2, h3, h4, h5, h6 { | ||
| a.anchor { |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
| .sl-c-link-header { | ||
|
|
||
| a { | ||
| h1, h2, h3, h4, h5, h6 { |
There was a problem hiding this comment.
Each selector in a comma sequence should be on its own single line
| @@ -61,3 +61,15 @@ | |||
| body | |||
| end | |||
| end | |||
|
|
|||
| after_render do |content, path, locs| | |||
There was a problem hiding this comment.
Lint/UnusedBlockArgument: Unused block argument - locs. If it's necessary, use _ or _locs as an argument name to indicate that it won't be used.
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
* Make link headers look and work more like GitHub's * Automatically generate links for all headers * Flash headers when they're selected * update readme
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
* Make link headers look and work more like GitHub's * Automatically generate links for all headers * Flash headers when they're selected * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the current header link styleguide to look and behave
more like GitHub header links.
Closes #230