-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add nice header linking behavior #280
Conversation
} | ||
|
||
&:target { | ||
animation-name: highlight-header; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered animation-duration, animation-name
} | ||
} | ||
|
||
&:hover a.anchor::after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
a { | ||
h1, h2, h3, h4, h5, h6 { | ||
a.anchor { | ||
display: block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered background, border, display, float, margin, vertical-align, width
|
||
a { | ||
h1, h2, h3, h4, h5, h6 { | ||
a.anchor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
.sl-c-link-header { | ||
|
||
a { | ||
h1, h2, h3, h4, h5, h6 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each selector in a comma sequence should be on its own single line
@@ -61,3 +61,15 @@ | |||
body | |||
end | |||
end | |||
|
|||
after_render do |content, path, locs| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/UnusedBlockArgument: Unused block argument - locs. If it's necessary, use _ or _locs as an argument name to indicate that it won't be used.
* Make link headers look and work more like GitHub's * Automatically generate links for all headers * Flash headers when they're selected * update readme
* Make link headers look and work more like GitHub's * Automatically generate links for all headers * Flash headers when they're selected * update readme
This adjusts the current header link styleguide to look and behave
more like GitHub header links.
Closes #230